Skip to content

chore(lint): Ensure EOL newlines#34117

Merged
agg23 merged 3 commits intomicrosoft:mainfrom
agg23:eslint-eol-newline
Dec 20, 2024
Merged

chore(lint): Ensure EOL newlines#34117
agg23 merged 3 commits intomicrosoft:mainfrom
agg23:eslint-eol-newline

Conversation

@agg23
Copy link
Copy Markdown
Contributor

@agg23 agg23 commented Dec 20, 2024

I've accidentally omitted trailing newlines several times. Add ESLint rules to ensure that can't happen.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@agg23 agg23 force-pushed the eslint-eol-newline branch from 981088e to 58f8ab5 Compare December 20, 2024 16:03
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

9 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-trace.spec.ts:343:5 › should work behind reverse proxy @ubuntu-latest-node22-1
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:239:1 › should reset tracing @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:44:3 › should use proxy for second page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/selector-generator.spec.ts:512:5 › selector generator › should generate exact placeholder when necessary @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:199:1 › should render console @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1078:1 › should display language-specific locators @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1537:1 › canvas clipping in iframe @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:245:3 › should upload large file with relative path @webkit-ubuntu-22.04-node18

37394 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants