Skip to content

feat(fetch/network): add generic to json method#34091

Merged
pavelfeldman merged 3 commits intomicrosoft:mainfrom
mmtv-qa:feat-add-generic-to-json-method-
Dec 19, 2024
Merged

feat(fetch/network): add generic to json method#34091
pavelfeldman merged 3 commits intomicrosoft:mainfrom
mmtv-qa:feat-add-generic-to-json-method-

Conversation

@mmtv-qa
Copy link
Copy Markdown
Contributor

@mmtv-qa mmtv-qa commented Dec 19, 2024

Added the ability to specify the JSON type as Generic during parsing to improve Development Expirience
If type is not specified, keep the original type (object)

Impact:

  • APIResponse
  • Response

@mmtv-qa
feat: add generic to json method
00b05c0 
added the ability to specify the json type during parsing
@mmtv-qa
Update types.d.ts
3693c4a
@github-actions

This comment has been minimized.

Sign in to view
@mmtv-qa
Copy link
Copy Markdown
Contributor Author

mmtv-qa commented Dec 19, 2024

@mmtv-qa please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2024

Test results for "tests 1"

6 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-macos-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/page-event-crash.spec.ts:73:1 › should be able to close context when page crashes @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:39:3 › should upload a folder @webkit-ubuntu-22.04-node18

37391 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit 94ffbcb into microsoft:main Dec 19, 2024
This was referenced Dec 19, 2024
Closed
Closed
Closed
pavelfeldman added a commit that referenced this pull request Dec 19, 2024
@pavelfeldman
Revert "feat(fetch/network): add generic to json method (#34091)"
482dbcd 
This reverts commit 94ffbcb.
@pavelfeldman pavelfeldman mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmtv-qa @pavelfeldman