Skip to content

docs: improve note on browser.close() behavior#34039

Merged
yury-s merged 2 commits intomicrosoft:mainfrom
yury-s:docs-browser-close-node
Dec 16, 2024
Merged

docs: improve note on browser.close() behavior#34039
yury-s merged 2 commits intomicrosoft:mainfrom
yury-s:docs-browser-close-node

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented Dec 16, 2024

@yury-s yury-s changed the title docs: better node on browser.close behavior docs: better noеe on browser.close behavior Dec 16, 2024
@yury-s yury-s changed the title docs: better noеe on browser.close behavior docs: better note on browser.close behavior Dec 16, 2024
@yury-s yury-s changed the title docs: better note on browser.close behavior docs: improve note on browser.close() behavior Dec 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › fixture-errors.spec.ts:471:5 › should not give enough time for second fixture teardown after timeout @macos-latest-node18-1
❌ [webkit-page] › page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

5 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:238:3 › should use socks proxy in second page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37305 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Page.onClose is not called with browser window is closed

2 participants