CHORE: Upgrade bundled ODBC driver from 18.5.1.1 to 18.6.2.1#569
Draft
gargsaumya wants to merge 2 commits into
Draft
CHORE: Upgrade bundled ODBC driver from 18.5.1.1 to 18.6.2.1#569gargsaumya wants to merge 2 commits into
gargsaumya wants to merge 2 commits into
Conversation
- Update Linux binaries (debian_ubuntu, rhel, alpine, suse) for x86_64 and arm64 - Replace libmsodbcsql-18.5.so.1.1 with libmsodbcsql-18.6.so.2.1 - Update libodbcinst.so.2 and license files - Add missing license file for suse/x86_64 - Update Windows binaries (x64, x86, arm64) - Replace msodbcsql18.dll, msodbcdiag18.dll, mssql-auth.dll, rll and license files - Update macOS binaries (arm64, x86_64) - Replace libmsodbcsql.18.dylib, rll and license files - Update ddbc_bindings.cpp to reference new .so filename - Update test_000_dependencies.py for new .so filename - Update pybind/build.sh comment for new .so filename - Update pr-validation-pipeline.yml with new Alpine APK URLs and ldd paths
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changes
Summary
📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 67.9%
mssql_python.row.py: 70.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 74.6%
mssql_python.pybind.connection.connection.cpp: 76.2%
mssql_python.__init__.py: 77.3%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 85.3%🔗 Quick Links
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request upgrades the Microsoft ODBC Driver for SQL Server from version 18.5.x to 18.6.2.1 across the CI pipeline and related scripts. The update ensures that all package downloads, verifications, and library checks are aligned with the new driver version, and also updates the bundled license file.
ODBC Driver Version Upgrade:
eng/pipelines/pr-validation-pipeline.ymlto use Microsoft ODBC Driver 18.6.2.1 instead of 18.5.x. This includes changes for x86_64 and arm64 on Debian/Ubuntu, RHEL, and Alpine distributions, as well as corresponding.solibrary checks. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]License File Update:
mssql_python/libs/linux/alpine/arm64/lib/MICROSOFT_ODBC_DRIVER_FOR_SQL_SERVER_LICENSE.txtto match the new driver version, including minor formatting and encoding changes.Other: