Skip to content

FIX: executemany RuntimeError when decimals change signs (GH-557) #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahnvi480 merged 12 commits into from
May 13, 2026
+73 −5
Merged

FIX: executemany RuntimeError when decimals change signs (GH-557) #560

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
db0c4d5
Fix executemany RuntimeError when decimals change signs (GH-557)
jahnvi480 May 8, 2026
813c06d
Optimize GH-557 fix: guard decimal scan with column check, reuse mate…
jahnvi480 May 11, 2026
2712bf2
Optimize GH-557 fix: guard decimal scan with column check, reuse mate…
jahnvi480 May 11, 2026
74feb1c
Optimize GH-557 fix: guard decimal scan with column check, reuse mate…
jahnvi480 May 11, 2026
77bd7ff
Eliminate double scan: compute max decimal formatted len inside _comp…
jahnvi480 May 11, 2026
71939e8
Merge branch 'main' into jahnvi/fix-executemany-decimal-sign-change-557
jahnvi480 May 11, 2026
e58e17e
Performing linting
jahnvi480 May 11, 2026
2eca508
Merge branch 'jahnvi/fix-executemany-decimal-sign-change-557' of http…
jahnvi480 May 11, 2026
dfdaaf9
Merge branch 'main' into jahnvi/fix-executemany-decimal-sign-change-557
jahnvi480 May 11, 2026
52ece94
Merge branch 'main' into jahnvi/fix-executemany-decimal-sign-change-557
jahnvi480 May 13, 2026
ebef56d
Merge branch 'main' into jahnvi/fix-executemany-decimal-sign-change-557
jahnvi480 May 13, 2026
ffa6987
Refine test docstring for test_executemany_decimal_sign_change
jahnvi480 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Optimize GH-557 fix: guard decimal scan with column check, reuse mate… 
…rialized column list
  • Loading branch information
@jahnvi480
jahnvi480 committed May 11, 2026
commit 74feb1cab3007b42409baace393a2c87f5dd2442
8 changes: 2 additions & 6 deletions mssql_python/cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2325,12 +2325,8 @@ def executemany( # pylint: disable=too-many-locals,too-many-branches,too-many-s
# Only scan when the already-materialized column actually contains
# Decimal values inferred as SQL_VARCHAR, and reuse that column data
# to avoid re-iterating the whole batch.
if (
paraminfo.paramSQLType == ddbc_sql_const.SQL_VARCHAR.value
and any(
value is not None and isinstance(value, decimal.Decimal)
for value in column
)
if paraminfo.paramSQLType == ddbc_sql_const.SQL_VARCHAR.value and any(
value is not None and isinstance(value, decimal.Decimal) for value in column
):
paraminfo.columnSize = max(
paraminfo.columnSize,
Expand Down
Loading