Skip to content

FIX: Release GIL during blocking ODBC connect/disconnect calls #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saurabh500 merged 10 commits into from
Apr 15, 2026
Merged

FIX: Release GIL during blocking ODBC connect/disconnect calls #497

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3fa8931
Release GIL during blocking ODBC connect/disconnect calls
saurabh500 Apr 6, 2026
47c61cf
Format code with black --line-length=100
saurabh500 Apr 6, 2026
83995e4
Add test for pool release overflow path (coverage lines 107-110)
saurabh500 Apr 6, 2026
60642be
Address review comments: error handling, pool accounting, test fix
saurabh500 Apr 6, 2026
def8f2c
Fix disconnect perf test: verify correctness not speedup ratio
saurabh500 Apr 7, 2026
b753411
Merge branch 'main' into dev/saurabh/gilduringconnect
saurabh500 Apr 8, 2026
d09dfd6
Remove unsafe LOG() call in destructor/shutdown disconnect path
saurabh500 Apr 10, 2026
b0eddec
Merge branch 'main' into dev/saurabh/gilduringconnect
saurabh500 Apr 10, 2026
9a9eb30
Merge branch 'main' into dev/saurabh/gilduringconnect
saurabh500 Apr 13, 2026
2a14a74
Merge branch 'main' into dev/saurabh/gilduringconnect
saurabh500 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format code with black --line-length=100 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@saurabh500
saurabh500 and Copilot committed Apr 6, 2026
commit 47c61cf383f5ebee18e5c65f0cd9e2c658a1b0f5
7 changes: 2 additions & 5 deletions tests/test_021_concurrent_connection_perf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,7 @@ def worker(idx):
except Exception as exc:
errors.append((idx, str(exc)))

threads = [
threading.Thread(target=worker, args=(i,), daemon=True)
for i in range(NUM_THREADS)
]
threads = [threading.Thread(target=worker, args=(i,), daemon=True) for i in range(NUM_THREADS)]

wall_start = time.perf_counter()
for t in threads:
Expand Down Expand Up @@ -233,7 +230,7 @@ def cpu_worker(idx):
while not stop_event.is_set():
# Busy work that requires the GIL
total = sum(range(10000))
_ = [x ** 2 for x in range(100)]
_ = [x**2 for x in range(100)]
cpu_counts[idx] += 1
except Exception as exc:
errors.append((f"cpu-{idx}", str(exc)))
Expand Down
Loading