Skip to content

FIX: Fixing test that does not work properly / Failing in connection pool #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subrata-ms wants to merge 9 commits into
base: main
Choose a base branch
from
Open

FIX: Fixing test that does not work properly / Failing in connection pool #493

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b733335
base code fix
subrata-ms Mar 31, 2026
f912215
Update mssql_python/pybind/connection/connection_pool.cpp
subrata-ms Apr 1, 2026
e6a7c54
Update mssql_python/pybind/connection/connection.cpp
subrata-ms Apr 1, 2026
17581ea
Update tests/test_009_pooling.py
subrata-ms Apr 1, 2026
78c51fd
test improvement
subrata-ms Apr 1, 2026
9a2978e
Merge branch 'main' into subrata-ms/ConnectionPoolTestFix
subrata-ms Apr 2, 2026
62b2762
Merge branch 'main' into subrata-ms/ConnectionPoolTestFix
subrata-ms Apr 2, 2026
e7a2d92
review comment
subrata-ms Apr 2, 2026
6b6cf82
fixing test failure
subrata-ms Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update mssql_python/pybind/connection/connection.cpp 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
  • Loading branch information
@subrata-ms
subrata-ms and Copilot authored Apr 1, 2026
commit e6a7c54b3414d0ac01e22de84e86120c7d02fe26
11 changes: 11 additions & 0 deletions mssql_python/pybind/connection/connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,17 @@ void Connection::disconnect() {
// from destructors, reset() failure paths, and pool cleanup.
// Throwing here during stack unwinding causes std::terminate().
LOG_ERROR("SQLDisconnect failed (ret=%d), forcing handle cleanup", ret);
Comment thread
subrata-ms marked this conversation as resolved.
Outdated

// Best-effort: retrieve and log ODBC diagnostics for debuggability.
// This must not throw, to keep disconnect noexcept-safe.
try {
ErrorInfo err = SQLCheckError_Wrap(SQL_HANDLE_DBC, _dbcHandle, ret);
std::string diagMsg = WideToUTF8(err.ddbcErrorMsg);
LOG_ERROR("SQLDisconnect diagnostics: %s", diagMsg.c_str());
} catch (...) {
// Swallow all exceptions: cleanup paths must not throw.
LOG_ERROR("SQLDisconnect: failed to retrieve ODBC diagnostics");
}
}
// Always free the handle regardless of SQLDisconnect result
_dbcHandle.reset();
Expand Down
Loading