Skip to content

feat: support suspend all setting #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chagong merged 8 commits into from
Jan 29, 2026
Merged

feat: support suspend all setting #619

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
845119b
feat: support suspend all setting
chagong Jan 21, 2026
e9bc5d4
fix: handle stoppedEvent for suspend policy change
chagong Jan 23, 2026
6f31817
fix: not allow change policy during a live debug session
chagong Jan 27, 2026
ba368b0
fix: format issue
chagong Jan 27, 2026
27b61d6
fix: let step command execute for current thread
chagong Jan 27, 2026
32924a1
fix: remove unused import
chagong Jan 27, 2026
283c1e4
fix: apply suspend policy to exception breakpoint
chagong Jan 28, 2026
67b9c6e
fix: improve naming
chagong Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: let step command execute for current thread
  • Loading branch information
@chagong
chagong committed Jan 27, 2026
commit 27b61d6b8b5e106c2dd49ccd1e215fc28e1d1af8
25 changes: 3 additions & 22 deletions ....core/src/main/java/com/microsoft/java/debug/core/adapter/handler/StepRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
import com.sun.jdi.StackFrame;
import com.sun.jdi.ThreadReference;
import com.sun.jdi.Value;
import com.sun.jdi.VMDisconnectedException;
import com.sun.jdi.VoidValue;
import com.sun.jdi.event.BreakpointEvent;
import com.sun.jdi.event.Event;
Expand Down Expand Up @@ -113,16 +112,8 @@ public CompletableFuture<Response> handle(Command command, Arguments arguments,
threadState.pendingStepRequest = DebugUtility.createStepOverRequest(thread, null);
}

if (context.getDebugSession().suspendAllThreads()) {
threadState.pendingStepRequest.setSuspendPolicy(EventRequest.SUSPEND_ALL);
}

threadState.pendingMethodExitRequest = thread.virtualMachine().eventRequestManager().createMethodExitRequest();
if (context.getDebugSession().suspendAllThreads()) {
threadState.pendingMethodExitRequest.setSuspendPolicy(EventRequest.SUSPEND_ALL);
} else {
threadState.pendingMethodExitRequest.setSuspendPolicy(EventRequest.SUSPEND_EVENT_THREAD);
}
threadState.pendingMethodExitRequest.setSuspendPolicy(EventRequest.SUSPEND_EVENT_THREAD);

threadState.targetStepIn = targetId > 0
? (MethodInvocation) context.getRecyclableIdPool().getObjectById(targetId) : null;
Expand Down Expand Up @@ -198,15 +189,7 @@ public CompletableFuture<Response> handle(Command command, Arguments arguments,
}

context.getThreadCache().removeEventThread(thread.uniqueID());
if (context.getDebugSession().suspendAllThreads()) {
try {
context.getDebugSession().resume();
} catch (VMDisconnectedException e) {
// ignore
}
} else {
DebugUtility.resumeThread(thread);
}
DebugUtility.resumeThread(thread);
ThreadsRequestHandler.checkThreadRunningAndRecycleIds(thread, context);
} catch (IncompatibleThreadStateException ex) {
// Roll back the Exception info if stepping fails.
Expand Down Expand Up @@ -327,9 +310,7 @@ private void handleDebugEvent(DebugEvent debugEvent, IDebugSession debugSession,
threadState.eventSubscription.dispose();
}
context.getThreadCache().addEventThread(thread, "step");
boolean allThreadsStopped = event.request() != null
&& event.request().suspendPolicy() == EventRequest.SUSPEND_ALL;
context.getProtocolServer().sendEvent(new Events.StoppedEvent("step", thread.uniqueID(), allThreadsStopped));
context.getProtocolServer().sendEvent(new Events.StoppedEvent("step", thread.uniqueID()));
debugEvent.shouldResume = false;
} else if (event instanceof MethodExitEvent) {
MethodExitEvent methodExitEvent = (MethodExitEvent) event;
Expand Down
3 changes: 1 addition & 2 deletions ...in/src/main/java/com/microsoft/java/debug/plugin/internal/JavaHotCodeReplaceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,8 +626,7 @@ private void stepIntoThread(ThreadReference thread) {
.take(1).subscribe(debugEvent -> {
debugEvent.shouldResume = false;
// Have to send to events to keep the UI sync with the step in operations:
boolean allThreadsStopped = request.suspendPolicy() == EventRequest.SUSPEND_ALL;
context.getProtocolServer().sendEvent(new Events.StoppedEvent("step", thread.uniqueID(), allThreadsStopped));
context.getProtocolServer().sendEvent(new Events.StoppedEvent("step", thread.uniqueID()));
context.getProtocolServer().sendEvent(new Events.ContinuedEvent(thread.uniqueID()));
});
request.enable();
Expand Down
Loading