Skip to content

Fix the step-into target on multi line expression. Fix #519 #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
testforstephen merged 4 commits into from
Jan 30, 2024
+9 −4
Merged

Fix the step-into target on multi line expression. Fix #519 #520

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ec67a0
Fix the step-into target on multi line expression. Fix #519
gayanper Nov 25, 2023
d52f8ba
Update StepRequestHandler.java
testforstephen Jan 30, 2024
efb32a6
Update MethodInvocationLocator.java
testforstephen Jan 30, 2024
ae6aa8e
Merge branch 'main' into multiline_statement_stepin
testforstephen Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update StepRequestHandler.java 
fix the comment
  • Loading branch information
@testforstephen
testforstephen authored Jan 30, 2024
commit d52f8baf73ba8a6e5c024bd9ddbcbe3b3ad7fe54
2 changes: 1 addition & 1 deletion ....core/src/main/java/com/microsoft/java/debug/core/adapter/handler/StepRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ private boolean isSameLocation(Location current, Location original, MethodInvoca
// expression which is wrapped.
return originalMethod.equals(currentMethod)
&& (original.lineNumber() == current.lineNumber()
|| (targetStepIn != null && targetStepIn.lineStart >= current.lineNumber()));
|| (targetStepIn != null && targetStepIn.lineEnd >= current.lineNumber()));
}

/**
Expand Down