Skip to content

Fix the perf issue when debug idea #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andxu merged 12 commits into from
Sep 21, 2017
Merged

Fix the perf issue when debug idea #42

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
db8af51
add unit test framework to use jdi to test formatters and lru cache p…
andxu Sep 20, 2017
146181b
modify line since 48 has no code.
andxu Sep 20, 2017
121aa50
add more test cases
andxu Sep 20, 2017
57d43a9
rename base test case
andxu Sep 20, 2017
042bb20
fix test case
andxu Sep 20, 2017
3450c06
make TEST_TIME_OUT constant
andxu Sep 20, 2017
3f64530
add variable util test
andxu Sep 20, 2017
2d9ae06
add launch.json for attaching debug engine itself
andxu Sep 20, 2017
6359bf3
Merge remote-tracking branch 'origin' into andy_debugger
andxu Sep 20, 2017
da9ecaf
fix the perf issue when a lot of sources are missing.
andxu Sep 21, 2017
6bca31d
Merge remote-tracking branch 'origin' into any_fixcacheissue
andxu Sep 21, 2017
b80a47e
fix a typo
andxu Sep 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...src/main/java/com/microsoft/java/debug/core/adapter/handler/StackTraceRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
import java.util.Arrays;
import java.util.List;

import org.apache.commons.lang3.StringUtils;

import com.microsoft.java.debug.core.DebugUtility;
import com.microsoft.java.debug.core.adapter.AdapterUtils;
import com.microsoft.java.debug.core.adapter.IDebugAdapterContext;
Expand Down Expand Up @@ -109,11 +111,13 @@ private Types.Source convertDebuggerSourceToClient(Location location, IDebugAdap

final String finalRelativeSourcePath = relativeSourcePath;
// use a lru cache for better performance
String uri = context.getSourceLookupCache().computeIfAbsent(fullyQualifiedName, key ->
context.getProvider(ISourceLookUpProvider.class).getSourceFileURI(key, finalRelativeSourcePath)
);
String uri = context.getSourceLookupCache().computeIfAbsent(fullyQualifiedName, key -> {
String fromProvider = context.getProvider(ISourceLookUpProvider.class).getSourceFileURI(key, finalRelativeSourcePath);
// avoid return null which will cause the compute function executed again
return StringUtils.isBlank(fromProvider) ? "" : fromProvider;
});

if (uri != null) {
if (!StringUtils.isBlank(uri)) {
String clientPath = AdapterUtils.convertPath(uri, context.isDebuggerPathsAreUri(), context.isClientPathsAreUri());
if (uri.startsWith("file:")) {
return new Types.Source(sourceName, clientPath, 0);
Expand Down