fix: return interface{} scanType for sql_variant instead of nil#362
Merged
dlevy-msft-sql merged 1 commit intoApr 20, 2026
Merged
Conversation
sql_variant columns returned nil from ColumnType.ScanType(), which
broke downstream libraries (e.g. Grafana) that rely on a non-nil
reflect.Type for all column types.
Since sql_variant can hold any SQL Server type, return reflect.Type
for interface{} which correctly represents the polymorphic nature
of the type.
Fixes microsoft#186
e98b256 to
9fb2eee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
===========================================
+ Coverage 80.00% 96.58% +16.57%
===========================================
Files 34 91 +57
Lines 6653 74078 +67425
===========================================
+ Hits 5323 71551 +66228
- Misses 1061 2190 +1129
- Partials 269 337 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
shueybubbles
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sql_variantcolumns returnednilfromColumnType.ScanType(), which broke downstream libraries (e.g. Grafana - see grafana/grafana#81935) that rely on a non-nilreflect.Typefor all column types.Changes
makeGoLangScanType()now returnsreflect.TypeOf((*interface{})(nil)).Elem()fortypeVariantinstead ofreflect.TypeOf(nil)Since
sql_variantcan hold any SQL Server type (int, varchar, datetime, etc.),interface{}is the correct Go scan type representing its polymorphic nature.Attribution
Thanks to @aangelisc for reporting this issue and identifying the root cause.
Fixes #186