Skip to content

Fix memory leak in zero_memory_deleter on non-Windows platforms #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaron-schulte wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix memory leak in zero_memory_deleter on non-Windows platforms #1808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix memory leak in zero_memory_deleter on non-Windows platforms 
Move delete data outside _WIN32 macro to prevent memory leaks on non-Windows platforms.
  • Loading branch information
@aaron-schulte
aaron-schulte committed Oct 31, 2024
commit 250554aeccfe11c6348208909cd0e8848af49304
2 changes: 1 addition & 1 deletion Release/src/utilities/web_utilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ void zero_memory_deleter::operator()(::utility::string_t* data) const
(void)data;
#ifdef _WIN32
SecureZeroMemory(&(*data)[0], data->size() * sizeof(::utility::string_t::value_type));
delete data;
#endif
delete data;
}
} // namespace details

Expand Down