Adding TypeScript Support and Removing github/codeql-go References - #50
Conversation
|
@microsoft-github-policy-service agree |
|
Michael Scovetta (@scovetta) , this looks good to merge too pending some changes.. Thanks Chris Sowley (@grizzls) |
SargeMonkey (sargemonkey)
left a comment
There was a problem hiding this comment.
We can remove line 67 too, and any related references to the folder
Done! |
| gettext && \ | ||
| apt-get clean && \ | ||
| rm -f /usr/bin/python /usr/bin/pip && \ | ||
| ln -s /usr/bin/python3.8 /usr/bin/python && \ |
There was a problem hiding this comment.
Not sure about the pip3 symlinking, but can this line not be replaced by also installing the python-is-python3 package?
There was a problem hiding this comment.
That's beyond the scope of this PR. All I want is TypeScript support and to fix the broken build. I'll leave that up to the maintainers
There was a problem hiding this comment.
I'll incorporate this comment into my next PR, thanks intrigus-lgtm!
|
@surajjacob Michael Scovetta (@scovetta) Anything else we need to do to get this merged? |
|
Suraj Jacob (@jacobmsft) & Michael Scovetta (@scovetta) any updates on getting this merged? |
you got it, sorry for the delay. |
When scanning javascript project that use typeScript, we are getting the following error:
nodejsto theDockerfile.github/codeql-gohas now moved togithub/codeqlthis change removes the relevant lines from theDockerfileSee: Relocation announcement:github/codeql-gomoving intogithub/codeqlgithub/codeql-go#741