Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Updating access-key rm command's help output#22

Merged
lostintangent merged 2 commits into
masterfrom
access_key_changes
Oct 16, 2015
Merged

Updating access-key rm command's help output#22
lostintangent merged 2 commits into
masterfrom
access_key_changes

Conversation

@lostintangent
Copy link
Copy Markdown
Member

@lostintangent lostintangent commented Oct 16, 2015

This changes does two things:

  1. Update the name of the accessKeyName parameter to simply accessKey, to better reflect the fact that the parameter expects the key value, not some kind of name for the key
  2. Updates the example to better reflect an actual scenario, since the use of "abc" as the key kind of implies that you're passing in some kind of label for the key

lostintangent
lostintangent reviewed Oct 16, 2015
View reviewed changes
Comment thread cli/script/command-parser.ts Outdated
Copy link
Copy Markdown
Member Author

@lostintangent lostintangent Oct 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! I'll fix the typo in the second access key mention

@shishirx34
Copy link
Copy Markdown
Contributor

shishirx34 commented Oct 16, 2015

LGTM

lostintangent added a commit that referenced this pull request Oct 16, 2015
@lostintangent
Merge pull request #22 from Microsoft/access_key_changes
8e97eed 
Updating access-key rm command's help output
@lostintangent lostintangent merged commit 8e97eed into master Oct 16, 2015
@lostintangent lostintangent deleted the access_key_changes branch October 16, 2015 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lostintangent @shishirx34