.NET: Fix intermittent checkpoint-restore race in in-process workflow runs#5134
Merged
.NET: Fix intermittent checkpoint-restore race in in-process workflow runs#5134
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an intermittent in-process checkpoint restore race where pre-restore queued external deliveries could be applied after checkpoint state import, leading to flaky replay behavior.
Changes:
- Clear queued external deliveries during
ImportStateAsyncso stale responses/messages from a superseded timeline can’t be applied post-restore. - Add a regression unit test to ensure a restored run remains
PendingRequestsuntil a fresh post-restore response is provided.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.Workflows/InProc/InProcessRunnerContext.cs | Clears queued external deliveries during checkpoint state import to prevent stale delivery application after restore. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/CheckpointResumeTests.cs | Adds a regression test validating queued responses from the superseded timeline don’t complete the restored run. |
westey-m
approved these changes
Apr 15, 2026
SergeyMenshykh
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During live
RestoreCheckpointAsync, queued external deliveries from the superseded timeline could survive restore and be applied after checkpoint state was imported. This caused flaky replay behavior in unit test sample execution, including incorrect prompt/order after restore.The change clears queued external deliveries during checkpoint import and adds a regression test to verify restored runs remain pending until a fresh post-restore response is sent.
Contribution Checklist