Skip to content

.NET: Suppress CodeQL false positive - #4948

Merged
westey (westey-m) merged 3 commits into
microsoft:mainfrom
westey-m:supress-codeql-false-positive
Mar 30, 2026
Merged

.NET: Suppress CodeQL false positive#4948
westey (westey-m) merged 3 commits into
microsoft:mainfrom
westey-m:supress-codeql-false-positive

Conversation

@westey-m

@westey-m westey (westey-m) commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

Motivation and Context

Description

Suppress false positive CodeQL issue.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings March 27, 2026 10:36
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the .NET Usage: [Issues, PRs], Target: .Net label Mar 27, 2026
@github-actions github-actions Bot changed the title Suppress CodeQL false positive .NET: Suppress CodeQL false positive Mar 27, 2026
Copilot AI reviewed Mar 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to suppress a reported CodeQL false positive in the .NET ChatClientAgent logging path.

Changes:

  • Adds an inline CodeQL suppression comment on a warning log call that includes the agent name.

Comment thread dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs Resolved
@westey-m
westey (westey-m) added this pull request to the merge queue Mar 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Mar 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Mar 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Mar 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Mar 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Mar 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Mar 30, 2026
@westey-m
westey (westey-m) removed this pull request from the merge queue due to a manual request Mar 30, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Mar 30, 2026
Merged via the queue into microsoft:main with commit 05c53dc Mar 30, 2026
21 checks passed
@SergeyMenshykh SergeyMenshykh mentioned this pull request Apr 1, 2026
Merged

This branch was previously deployed

1 inactive deployment
integration — 0150b942 Deployed Mar 30, 2026 by westey-m via dotnet-test (net10.0, ubuntu-latest, Release, true, integration) #15726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rogerbarreto Roger Barreto (rogerbarreto) rogerbarreto approved these changes
@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

Assignees

No one assigned

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@westey-m @rogerbarreto @SergeyMenshykh @markwallace-microsoft