Skip to content

Add WebGL 1 types#533

Merged
mhegazy merged 2 commits into
microsoft:masterfrom
saschanaz:webgl
Jul 31, 2018
Merged

Add WebGL 1 types#533
mhegazy merged 2 commits into
microsoft:masterfrom
saschanaz:webgl

Conversation

@saschanaz
Copy link
Copy Markdown
Collaborator

WebGL 2 types will follow later.

"title": "WebDriver"
},
{
"url": "https://www.khronos.org/registry/webgl/specs/latest/1.0/webgl.idl",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a licence/terms of use for this one. the other ones all came from w3.org or whatwg, and both have licences/terms of use docs on their specs, we have included the licencees in the TS Third Party Notice. See https://github.com/Microsoft/TypeScript/blob/master/ThirdPartyNoticeText.txt#L82-L167

Can you file a bug for the Khronos group to add a licence text/terms of use documents to the spec so we can safely use it.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this: https://www.khronos.org/legal/terms-of-use/ or do we need something else?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the copyright notice:

The contents of this site are subject to protection under U.S. and foreign copyright laws. You may not copy or distribute any portion of this site, except as necessary to view this site.

I think they need to have explicit terms of use on the documents themselves. for example: this is what W3C has, and they have it linked from all their specs: https://www.w3.org/Consortium/Legal/2015/copyright-software-and-document

WhatWG uses Creative Commons Attribution 4.0 International License, and again, they have it linked in all their specs.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got the license: KhronosGroup/WebGL#267

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jul 31, 2018

Thanks!

@mhegazy mhegazy merged commit 6177585 into microsoft:master Jul 31, 2018
mhegazy added a commit to microsoft/TypeScript that referenced this pull request Jul 31, 2018
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jul 31, 2018

Ported by microsoft/TypeScript#26102

@saschanaz saschanaz deleted the webgl branch July 31, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants