Skip to content

ReadyState type is a string#31

Merged
zhengbli merged 1 commit into
microsoft:masterfrom
MattiasBuelens:ReadyState
Jan 6, 2016
Merged

ReadyState type is a string#31
zhengbli merged 1 commit into
microsoft:masterfrom
MattiasBuelens:ReadyState

Conversation

@MattiasBuelens
Copy link
Copy Markdown
Contributor

MediaSource.readyState is a ReadyState string enum, but TypeScript reports it to be a number.

@msftclas
Copy link
Copy Markdown

Hi @MattiasBuelens, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link
Copy Markdown

@MattiasBuelens, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@zhengbli
Copy link
Copy Markdown

zhengbli commented Jan 6, 2016

LGTM 👍
Thanks for contributing @MattiasBuelens !

zhengbli pushed a commit that referenced this pull request Jan 6, 2016
@zhengbli zhengbli merged commit 5cfeb56 into microsoft:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants