Skip to content

Add missing optional constructor param for Text#229

Merged
mhegazy merged 1 commit into
microsoft:masterfrom
alexeagle:master
Apr 13, 2017
Merged

Add missing optional constructor param for Text#229
mhegazy merged 1 commit into
microsoft:masterfrom
alexeagle:master

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

/cc @samccone

@msftclas
Copy link
Copy Markdown

msftclas commented Apr 4, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@saschanaz
Copy link
Copy Markdown
Collaborator

saschanaz commented Apr 5, 2017

The file must not be modified:
image

Instead you can modify [added/overriding/removed]Types.json.

@alexeagle
Copy link
Copy Markdown
Contributor Author

alexeagle commented Apr 5, 2017 via email

@saschanaz
Copy link
Copy Markdown
Collaborator

You'll want to look at addedTypes.json to add a constructor to an interface.

@saschanaz
Copy link
Copy Markdown
Collaborator

Make sure you get pass on the build script to solve the CI failure! The generated directory will have new files and you have to copy-paste them to baselines directory.

@alexeagle alexeagle force-pushed the master branch 2 times, most recently from e35e298 to d6b5214 Compare April 5, 2017 05:33
@alexeagle
Copy link
Copy Markdown
Contributor Author

The CI only says that the generated file doesn't match the baseline, without printing the diff. I guess I'll have to install Mono so I can generate the files locally.

@alexeagle
Copy link
Copy Markdown
Contributor Author

Thanks for the help @saschanaz !

@samccone
Copy link
Copy Markdown

samccone commented Apr 5, 2017

Thanks @alexeagle

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Apr 13, 2017

Link to documentation: https://dom.spec.whatwg.org/#text

For future purposes, please file an issue on the TS repo along with the change.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Apr 13, 2017

thanks!

@mhegazy mhegazy merged commit fb07b70 into microsoft:master Apr 13, 2017
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Apr 13, 2017

and thanks @saschanaz!

@samccone
Copy link
Copy Markdown

thank you for landing @mhegazy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants