Fix event types of XMLHttpRequest#110
Closed
falsandtru wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
How can I override |
Contributor
Author
|
@zhengbli Are you supported signature overriding like this? |
Contributor
|
ping @zhengbli |
|
Overriding the signatures of |
Contributor
Author
|
Any updates? |
|
Actually I found it is easier to change the emitting F# code. I sent another PR at #144, sorry for the delay. |
Contributor
Author
|
LGTM 👍 |
orta
added a commit
to orta/TSJS-lib-generator
that referenced
this pull request
Jul 1, 2021
…s an extendable interface (microsoft#110) * Bring back the EventListenerOrEventListenerObject and EventListener as an extendable interface * Merge main * Use th existing build infra to add the eventlistener * Docs * Eslint fix * No circular reference * Remove call signature code * Final removal * Remove the hack for EventListenerOrEventListenerObject * Update src/build.ts Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com> * User override types for EventTarget * Update src/build/emitter.ts Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/TypeScript#8691