Integrate feedback from @mihailik to performance framework#9845
Merged
Conversation
| @@ -1,107 +1,110 @@ | |||
| /*@internal*/ | |||
| namespace ts { | |||
Contributor
There was a problem hiding this comment.
should this also be /*@internal*/?
Member
Author
There was a problem hiding this comment.
Do we not want to publicly expose timestamp? I guess we don't have a good reason to expose it, so may as well not.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates @mihailik's comments from #9536. Also flattens the namespaces in
performance.ts(removing mostly meaningless whitespace), and unifies all timestamping found in the compiler to use a singletimestampfunction.The definition of
timestampis still inperformance, sinceperformancestill needs to use it, and it defined beforecore.@rbuckton Do you wanna okay this change?