Create separate constructors for Tokens and Identifiers#9529
Merged
Conversation
| flags: NodeFlags; | ||
| } | ||
|
|
||
| export interface Token extends Node { } |
Member
There was a problem hiding this comment.
Consider a __tokenTag
…stent among nodes, tokens and identifiers
| public jsDocComments: JSDocComment[]; | ||
| public __tokenTag: any; | ||
|
|
||
| constructor(public pos: number, public end: number) { |
Contributor
There was a problem hiding this comment.
can you list all assignments to properties in the same order as in the NodeObject ?
Member
Author
There was a problem hiding this comment.
They are in same order as node object
Contributor
There was a problem hiding this comment.
i understand. it just took me a bit to verify that by looking at the ones done in the constructor explicitly and the ones done because they are parameter properties.
my comment is to not use parameter properties just to make it clear what the order is.
also worth adding a comment that these need to stay in sync on all three classes.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.