Refactor module resolution logic to have configurable goal extensions #9430
Add another test
- Loading branch information
commit 7894136f29cf51e4407dbb34bbfb3776a6b7af8f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,6 @@ | |
| "inputFiles": [ | ||
| "index.ts" | ||
| ], | ||
| "baselineCheck": true, | ||
| "moduleResolution": "node" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "scenario": "Realistic npm package types with package.json", | ||
| "projectRoot": "tests/cases/projects/realisticNpmTypes2", | ||
| "inputFiles": [ | ||
| "index.ts" | ||
| ], | ||
| "baselineCheck": true, | ||
| "moduleResolution": "node" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import m1 = require("m1"); | ||
|
|
||
| const val = m1("works", 42); | ||
| void `${m1.name}: ${val}`; | ||
|
|
||
| export {m1}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not specifying
allowJs, that's why this is working even with the above bug, as you are never even checking for .js files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'doh. It's just added by default in so many places that I thought this may be one of them. Added and fixed.