Object whitespace rule#9332
Merged
Merged
Conversation
Member
Author
| if (node.kind === ts.SyntaxKind.ObjectLiteralExpression) { | ||
| const literal = node as ts.ObjectLiteralExpression; | ||
| const text = literal.getText(); | ||
| if (text.match(/^{[^\n]+}$/g)) { |
Member
There was a problem hiding this comment.
can you check for exactly one instead of at least one?
Member
Author
|
Now looks for exactly one space. |
| } | ||
| } | ||
|
|
||
| class ObjectLiteralSpaceWalker extends Lint.RuleWalker { |
Member
There was a problem hiding this comment.
maybe should be SkyWalker instead of SpaceWalker?
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at the end of #9068 - this codifies our object literal whitespace lint rules.
If an object literal is on a single line, it must have a space at the beginning and at the end.