Signatures use JSDoc to determine optionality#9303
Merged
Conversation
|
|
||
| if (hasQuestionToken(node)) { | ||
| function isOptionalParameter(node: ParameterDeclaration) { | ||
| if (isJSDocOptionalParameter(node) || hasQuestionToken(node)) { |
Member
There was a problem hiding this comment.
Swap this check around so that the TS check is faster for the positive case.
Member
Author
There was a problem hiding this comment.
Maybe. Isn't flags & NodeFlags.JavaScriptFile faster than switch(node.kind) with 7 cases? In other words, I think the speed gain will be absolutely tiny. And the code was originally written in this order, although that's (apparently) not meaningful.
Member
Author
There was a problem hiding this comment.
Regardless of performance, I think I like the way it reads better to flip it.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9228