Skip to content

Fix 8355: Fix emit metadata different between transpile and tsc --isolatedModule #9232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuit merged 8 commits into from
Jun 25, 2016
Merged

Fix 8355: Fix emit metadata different between transpile and tsc --isolatedModule #9232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5113c0f
Instead of returning undefined for unknownSymbol return itself
Jun 16, 2016
760f765
Add Transpile unittest
Jun 16, 2016
bad4d34
Wip - Add project tests
Jun 16, 2016
10bbdf5
Add project tests and baselines
Jun 17, 2016
1f7309d
Update existed tests
Jun 17, 2016
8b128d9
Merge branch 'fix8355_emitmetadata' of https://github.com/Microsoft/T…
Jun 17, 2016
e843908
Add tests for emitting metadata with module targetting system
Jun 17, 2016
505f80c
Merge branch 'master' into fix8355_emitmetadata
Jun 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update existed tests
  • Loading branch information
Kanchalai Tanglertsampan committed Jun 17, 2016
commit 1f7309d8ac828d9bc66ef1228d21f2d6e49d43a4
3 changes: 2 additions & 1 deletion tests/baselines/reference/decoratorMetadataWithImportDeclarationNameCollision4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ var MyClass = (function () {
}
MyClass = __decorate([
someDecorator,
__metadata('design:paramtypes', [Object])
__metadata('design:paramtypes', [(typeof (_a = typeof db_1.default !== 'undefined' && db_1.default.db) === 'function' && _a) || Object])
], MyClass);
return MyClass;
var _a;
}());
exports.MyClass = MyClass;
2 changes: 2 additions & 0 deletions tests/cases/unittests/transpile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ var x = 0;`, {
compilerOptions: {
target: ScriptTarget.ES5,
module: ModuleKind.CommonJS,
moduleResolution: ModuleResolutionKind.NodeJs,
emitDecoratorMetadata: true,
experimentalDecorators: true,
isolatedModules: true,
Expand All @@ -273,6 +274,7 @@ var x = 0;`, {
compilerOptions: {
target: ScriptTarget.ES5,
module: ModuleKind.System,
moduleResolution: ModuleResolutionKind.NodeJs,
emitDecoratorMetadata: true,
experimentalDecorators: true,
isolatedModules: true,
Expand Down