Skip to content

Fix #6319: Add support for --t: es5 and --m es6#9042

Merged
mhegazy merged 7 commits into
masterfrom
ES6ModulesES5Target
Jun 10, 2016
Merged

Fix #6319: Add support for --t: es5 and --m es6#9042
mhegazy merged 7 commits into
masterfrom
ES6ModulesES5Target

Conversation

@mhegazy
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy commented Jun 9, 2016

Fixes #6319.

sheetalkamat
sheetalkamat reviewed Jun 9, 2016
View reviewed changes
Comment thread tests/baselines/reference/es6modulekindWithES5Target9.symbols Outdated
@@ -0,0 +1,12 @@
=== tests/cases/compiler/es6modulekindWithES5Target9.ts ===
Copy link
Copy Markdown
Member

@sheetalkamat sheetalkamat Jun 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code here looks different from tests/baselines/reference/es6modulekindWithES5Target9.js ?

Copy link
Copy Markdown
Contributor Author

@mhegazy mhegazy Jun 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. earlier files that i have used and did not delete.

sheetalkamat
sheetalkamat reviewed Jun 9, 2016
View reviewed changes
Comment thread tests/cases/compiler/es6modulekindWithES5Target9.ts
import {a} from "mod";

import * as M from "mod";

Copy link
Copy Markdown
Member

@sheetalkamat sheetalkamat Jun 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add usage of d, a, M etc to verify exports.identifier is not being emitted

Copy link
Copy Markdown
Contributor Author

@mhegazy mhegazy Jun 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mhegazy
Copy link
Copy Markdown
Contributor Author

mhegazy commented Jun 9, 2016

@sheetalkamat any more comments?

@sheetalkamat
Copy link
Copy Markdown
Member

sheetalkamat commented Jun 10, 2016

👍

@mhegazy mhegazy merged commit 97d7aa5 into master Jun 10, 2016
@mhegazy mhegazy deleted the ES6ModulesES5Target branch June 10, 2016 17:23
@jayphelps jayphelps mentioned this pull request Jun 10, 2016
Closed
@texastoland
Copy link
Copy Markdown
Contributor

texastoland commented Jun 10, 2016

CC @Victorystick!

@Victorystick
Copy link
Copy Markdown

Victorystick commented Jun 11, 2016

Woop! This is fantastic news! 🎉 In which stable version can we expect to see these changes?

@mariusschulz
Copy link
Copy Markdown
Contributor

mariusschulz commented Jun 11, 2016

Yey, great to see this feature! 🎉

@Victorystick The roadmap lists it underneath 2.0.

@texastoland
Copy link
Copy Markdown
Contributor

texastoland commented Jun 11, 2016

It was merged into master so I assume 1.9 though and testable in nightly 1.9.0-dev.20160610-1.0?

@mhegazy
Copy link
Copy Markdown
Contributor Author

mhegazy commented Jun 11, 2016

correct. today's build should have the fix. it should be shipped as part of the next release (TS 2.0).

@sod sod mentioned this pull request Jun 17, 2016
Closed
@MarkPieszak MarkPieszak mentioned this pull request Jul 31, 2016
Merged
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mhegazy @sheetalkamat @texastoland @Victorystick @mariusschulz @msftclas