Support using string values in enums for CompilerOptions in transpile#8988
Merged
5 commits merged intoJun 9, 2016
Merged
Conversation
| return options; | ||
| } | ||
|
|
||
| const stringValuedEnums = <CommandLineOptionOfCustomType[]>filter(optionDeclarations, o => { |
Contributor
There was a problem hiding this comment.
nit, i would move this before the function. also consider renaming it to include commandLine somewhere.
Contributor
|
👍 |
added 2 commits
June 6, 2016 13:31
Contributor
|
request for additional test. other than that, looks good to me. |
added 2 commits
June 9, 2016 05:59
(commandLineOptions_stringToEnum would be undefined if optionDeclarations wasn't loaded yet)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7980
This doesn't change the CompilerOptions type, so only JS consumers can use strings.