[Transforms] Performance improvements in the comment emitter.#8906
Merged
Conversation
…s, and source maps.
| else { | ||
| disabled = true; | ||
| emitCallback(node); | ||
| disabled = false; |
Contributor
There was a problem hiding this comment.
maybe it should save previous value of disabled and restore it later instead of unconditionally set it to false?
Contributor
Author
There was a problem hiding this comment.
There is no need, the first branch handles that case.
| @@ -594,10 +594,15 @@ namespace ts { | |||
| * and the next token are returned. | |||
| * If true, comments occurring between the given position and the next line break are returned. | |||
Contributor
There was a problem hiding this comment.
should these comment get updated?
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the comment emitter and reduces allocations for Comment Ranges. Also allows the
runtests-filejake task to run in parallel.