Skip to content

Reorder options alphabetically#8850

Merged
mhegazy merged 4 commits into
masterfrom
reorderOptions
Jun 8, 2016
Merged

Reorder options alphabetically#8850
mhegazy merged 4 commits into
masterfrom
reorderOptions

Conversation

@mhegazy
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy commented May 27, 2016

order compiler options alphabetically and mark ones that are only used in tsc.ts (e.g. pretty, list files, diagnostics) as internal.

@basarat
Copy link
Copy Markdown
Contributor

basarat commented May 27, 2016

Thanks. Will make keeping this list updated much less painful :) 🌹

Comment thread src/compiler/types.ts Outdated
typesRoot?: string;
types?: string[];
/* @internal */ typesRoot?: string;
typesSearchPaths?: string[]; // Path used to used to compute primary search locations
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment used to be on typesRoot I think

@sandersn
Copy link
Copy Markdown
Member

👍 with a couple of comments about comments

Comment thread src/compiler/types.ts Outdated
allowUnusedLabels?: boolean;
baseUrl?: string;
charset?: string;
/* @internal */ configFilePath?: string; // When options come from a config file, its path is recorded here
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you reduce space before comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just put the comment above as a JSDoc so you can actually get a tooltip

@yuit
Copy link
Copy Markdown
Contributor

yuit commented May 27, 2016

👍

@mhegazy mhegazy merged commit 6b8109a into master Jun 8, 2016
@mhegazy mhegazy deleted the reorderOptions branch June 8, 2016 20:35
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants