Skip to content

Fix #8795: make properties defined in optional constructor parameters optional#8825

Merged
mhegazy merged 3 commits into
masterfrom
Fix8795-1
May 26, 2016
Merged

Fix #8795: make properties defined in optional constructor parameters optional#8825
mhegazy merged 3 commits into
masterfrom
Fix8795-1

Conversation

@mhegazy
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy commented May 25, 2016

Fixes #8795

@ahejlsberg ahejlsberg changed the title Fix #8795: make properties defined in optional constructor paramters optional Fix #8795: make properties defined in optional constructor parameters optional May 25, 2016
@ahejlsberg
Copy link
Copy Markdown
Member

👍

v = v2; // Should fail
var v3: { x } = new C; // Should succeed
v = v2; // Should succeed
var v3: { x } = new C; // Should fail
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time these comments need to be updated, I wonder if they ever should have been there to begin with. You have already have the error messages.

@mhegazy mhegazy merged commit 6173696 into master May 26, 2016
@mhegazy mhegazy deleted the Fix8795-1 branch May 26, 2016 00:11
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants