Skip to content

Do not resolve alias when getting symbol of import equal's right hand side#8789

Merged
sheetalkamat merged 1 commit into
masterfrom
getSymbolAtAliasLocation
May 27, 2016
Merged

Do not resolve alias when getting symbol of import equal's right hand side#8789
sheetalkamat merged 1 commit into
masterfrom
getSymbolAtAliasLocation

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

This helps searching correct symbols when renaming.
Fixes #5501

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 25, 2016

thanks, we should have added this a while back. we now add Alias to lookup flags, in places like in getSymbolOfEntityNameOrPropertyAccessExpression, so we should remove these too. but that can be in a different PR.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 25, 2016

👍

@sheetalkamat sheetalkamat merged commit 3515652 into master May 27, 2016
@sheetalkamat sheetalkamat deleted the getSymbolAtAliasLocation branch May 27, 2016 16:27
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants