Lint unit tests via harnessSources in Jakefile.js#8785
Merged
Conversation
Member
Author
|
@Andy-MS can you take a look? |
| }); | ||
| var lintTargets = compilerSources | ||
| .concat(harnessCoreSources) | ||
| .concat(harnessSources) |
There was a problem hiding this comment.
Don't need client.ts added manually below, that's already in harnessSources.
Member
Author
There was a problem hiding this comment.
Thanks for the reminder. fixed.
Contributor
|
👍 |
| ///<reference path='..\..\..\..\src\harness\harness.ts' /> | ||
|
|
||
| describe("DocumentRegistry", () => { | ||
| /* tslint:disable no-unused-variable */ |
There was a problem hiding this comment.
Should there be an issue reminding us to go and fix things like this later?
Member
Author
There was a problem hiding this comment.
No, these variables are intentionally unused because they are testing state sharing between instances.
|
Printing |
Member
Author
|
I'm not sure of the correct Javascript way to do this. Gets rid of 3 dupes: protocol.d.ts, session.ts and editorServices.ts. |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of preprocessing tests needed to change because of deleting trailing whitespace. Otherwise the changes are straightforward.
Fixes #8763