run tests in parallel by equally dividing them between workers#8774
Merged
Conversation
| complete(); | ||
| }); | ||
| lint.invoke(); | ||
| if (i === 0) { |
Member
There was a problem hiding this comment.
shouldn't need this check for the non-parallel version
|
|
||
| type TestRunnerKind = CompilerTestKind | FourslashTestKind | "project" | "rwc" | "test262"; | ||
| type CompilerTestKind = "conformance" | "compiler"; | ||
| type FourslashTestKind = "fourslash" | "fourslash-shims" | "fourslash-shims-pp" | "fourslash-server"; |
Member
There was a problem hiding this comment.
these don't need to be in order? That's strange
Member
|
👍 |
|
|
||
| } | ||
| else { | ||
| // run task to load all tests and partition then between workers |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
difference from current implementation of
runtests-parallel: instead of partitioning statically on per-category basis we first load a list of tests and equally divide every category based on the number of workers (by default is set torequire("os").cpus().length).Running times (with
lint=false) on Intel(R) Core(TM) i7 CPU 860 @ 2.80GHz, RAM 16 GB: