Skip to content

Fixes #8582: Add Error.prototype.stack definition#8609

Merged
mhegazy merged 1 commit into
microsoft:masterfrom
nojvek:master
May 16, 2016
Merged

Fixes #8582: Add Error.prototype.stack definition#8609
mhegazy merged 1 commit into
microsoft:masterfrom
nojvek:master

Conversation

@nojvek
Copy link
Copy Markdown
Contributor

@nojvek nojvek commented May 15, 2016

Fixes #8582: Add Error.prototype.stack definition

@DanielRosenwasser
Copy link
Copy Markdown
Member

Hey @nojvek, fixes are supposed to go into src/lib (check out the files CONTRIBUTING.md and src/lib/README.md) and then we generally update the LKG when we deem appropriate. We also try not to change line endings in existing files. Could you resubmit so we can get a reasonable diff and generate the files appropriately?

@DanielRosenwasser
Copy link
Copy Markdown
Member

Basically what I'm also saying is: only add the definition into src/lib/ where it needs to go, don't run jake LKG.

@nojvek
Copy link
Copy Markdown
Contributor Author

nojvek commented May 16, 2016

Yeah I totally forgot to push so it has the old commit. My bad. Sorry. I had made the edit in src/lib/es5.d.ts

@nojvek
Copy link
Copy Markdown
Contributor Author

nojvek commented May 16, 2016

Fixed now.

@DanielRosenwasser
Copy link
Copy Markdown
Member

That's a much nicer diff 😄 👍

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 16, 2016

thanks!

@mhegazy mhegazy merged commit ef75346 into microsoft:master May 16, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants