Conversation
Contributor
Author
|
//cc: @vladima |
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| !!! error TS2304: Cannot find name 'SomeNonExistingName'. | ||
| ~~~~~~~~~~~~~~~~~~~ | ||
| !!! error TS2304: Cannot find name 'SomeNonExistingName'. |
Contributor
There was a problem hiding this comment.
extra cannot find name 'name' errors look annoying and not very useful, can we do something to suppress them?
this is related to pretty much all changes in error baselines
Contributor
Author
There was a problem hiding this comment.
@vladima, i removed the older Cannot find name error, as it was generated during declaration emit, and was not really needed. the new one however, is produced as we now call checkExpression to make sure we mark the identifier. i do not think there is an easy way to do that, unless we wire in a flag into checkExpression functions to not report errors. i do not think it is worth the complexity though.
Contributor
Author
|
@vladima any more comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8507
This is important for JS files. regardless if we found the module or not, we should be always emitting the import/export to grantee valid transpilation. Also note that this is the same behavior for
--isolatedModules, and it is currently an error case anyways, so there should not be any breaks from changing this behavior to working code.