Add asserts to help diagnose signature help crash #832#848
Merged
Conversation
Contributor
|
👍 |
JsonFreeman
added a commit
that referenced
this pull request
Oct 7, 2014
Add asserts to help diagnose signature help crash #832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug #832 is a crash that I cannot reproduce. There are a few plausible causes for this crash, so I'm adding a few asserts to catch these cases in an effort to learn more. These asserts should not be fatal, and they should not degrade the user experience.
The basic problem is that we are looking at the children of a call expression, trying to find a list child that contains a given span. The 2 asserts I have do the following: