Conversation
| } | ||
|
|
||
| interface Set<T> { | ||
| [Symbol.iterator]():IterableIterator<T>; |
Contributor
There was a problem hiding this comment.
should not this be in iterable.d.ts?
Contributor
Author
There was a problem hiding this comment.
I put it here as it uses Symbol.iterator. Though same argument can go with the return type
Contributor
There was a problem hiding this comment.
I think iterator is different, and should be in iterables and not in the wellknwon symbols.
Contributor
Author
There was a problem hiding this comment.
Just curious why they are different?
Contributor
There was a problem hiding this comment.
Iterable definition depends on Symbol.Iterator. it is rather meaningless to have iterables and not the definition of Symbol.Iterator.
the other ones are self contained, you can chose to use them or not.
Contributor
|
one comment about empty interface declaration, other than that, looks good. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8407 and move iterable and symbol into correct file