Skip to content

Remove name length limit in navigation bar service for function expression#8403

Merged
mhegazy merged 1 commit into
microsoft:masterfrom
d4rkr00t:navbar
Apr 30, 2016
Merged

Remove name length limit in navigation bar service for function expression#8403
mhegazy merged 1 commit into
microsoft:masterfrom
d4rkr00t:navbar

Conversation

@d4rkr00t
Copy link
Copy Markdown
Contributor

Hi, what do you think about removing length limit in navigation bar service for function expression?

It might be very useful for example in Visual Studio Code. VSCode uses navigation bar service for "jump to symbol". And when there is a function expression with long name it shows only 17 characters.

Current behaviour:
screen shot 2016-04-23 at 22 42 22

After changes from this PR:
screen shot 2016-04-23 at 22 43 11

Here is code on which you can check current behaviour:

blocks['some-block-with-long-name'] = function(params) {}
blocks['some-block-with-long-name2'] = function(params) {}
blocks['some-block-with-long-name3'] = function(params) {}
blocks['some-block-with-long-name4-much-longer-that-i-have-ever-exptected-it-to-be-so-it-doesnt-fit-in-one-line'] = function(params) {}

And this limit looks a bit strange because if you put var in front of function expression you'll get whole name. So it should not break anything :).

test_variable_with_very_long_name_much_longer_that_i_ve_ever_expected = function(params) {}
var test_variable_with_very_long_name_much_longer_that_i_ve_ever_expected2 = function(params) {}

screen shot 2016-04-30 at 22 01 17

@msftclas
Copy link
Copy Markdown

Hi @d4rkr00t, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Apr 30, 2016

Fixes #8238

@mhegazy mhegazy merged commit bc5b6dc into microsoft:master Apr 30, 2016
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Apr 30, 2016

thanks!

@d4rkr00t
Copy link
Copy Markdown
Contributor Author

Wow, thank you :) It was the fastest merge I've ever seen. :)

@d4rkr00t d4rkr00t deleted the navbar branch April 30, 2016 19:30
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants