Remove name length limit in navigation bar service for function expression#8403
Merged
Conversation
|
Hi @d4rkr00t, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Contributor
|
Fixes #8238 |
Contributor
|
thanks! |
Contributor
Author
|
Wow, thank you :) It was the fastest merge I've ever seen. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, what do you think about removing length limit in navigation bar service for function expression?
It might be very useful for example in Visual Studio Code. VSCode uses navigation bar service for "jump to symbol". And when there is a function expression with long name it shows only 17 characters.
Current behaviour:

After changes from this PR:

Here is code on which you can check current behaviour:
And this limit looks a bit strange because if you put
varin front of function expression you'll get whole name. So it should not break anything :).