[Transforms] Fixes for ShorthandPropertyAssignments and exported namespaces#8233
Merged
rbuckton merged 2 commits intoApr 22, 2016
Merged
Conversation
| if (substitution && (getNodeEmitFlags(node) & NodeEmitFlags.NoSubstitution) === 0) { | ||
| const substitute = substitution(node); | ||
| function tryEmitSubstitute(node: Node, emitNode: (node: Node) => void, isExpression: boolean) { | ||
| if ((<any>node).text === "localizedDiagnosticMessages" && isExpression) { |
Contributor
There was a problem hiding this comment.
do not think you need this.
Contributor
Author
There was a problem hiding this comment.
Ah, thanks. Left-over from trying to fix an issue.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change revises how JIT substitution works in the printer. Previously we had two hooks for substitution on
TransformationContext:identifierSubstitutionandexpressionSubstitution. Now, we instead have a single hook,onSubstituteNode, which adds an additionalisExpressionparameter that will be provided a value indicating whether the node to be substituted is expected to be used as an expression.This change allows us to easily add substitutions for a node that is neither an identifier nor an expression, such as a
ShorthandPropertyAssignment.Fixes #7862.
Fixes the following tests: