[Transforms] Capture this in computed property names in arrow functions#8069
Merged
sandersn merged 3 commits intoApr 14, 2016
Conversation
this in computed property names in arrow functionsthis in computed property names in arrow functions
| // is an ES6 node. | ||
| transformFlags = TransformFlags.AssertES6; | ||
| } | ||
| if (subtreeFlags & TransformFlags.ContainsLexicalThisInComputedPropertyName) { |
Contributor
There was a problem hiding this comment.
Could you add comment about the discussion you have with @rbuckton why you convert this to "ContainsLexicalThis"
Contributor
|
👍 (after adding comments per @yuit above) |
Contributor
|
👍 after add comment. |
Member
Author
|
OK, it's done, but it is surprisingly hard to explain in writing. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7860
Fixes baselines: