[Transforms] fix Not correctly emitting local name for exported class#8048
Merged
Conversation
| } | ||
|
|
||
| // Set emitFlags on the name of the classDeclaration | ||
| // This is so that when printer will not substitute the identifier |
Member
There was a problem hiding this comment.
- Should it be "Set emitFlags on the name of the importEqualsDeclaration" ?
- I think the second line should be reworded as "This is so the printer ..." ('that when' -> 'the')
Member
There was a problem hiding this comment.
Same wording comments on the other two comment changes too
Member
|
👍 after minor comment changes |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7864
@rbuckton, let me know if this is the correct way to go