fix emit for super calls that has preceding prologue directives#8028
Merged
Conversation
| * @returns index of the statement that follows super call | ||
| */ | ||
| function findInitialSuperCall(ctor: ConstructorDeclaration): ExpressionStatement { | ||
| function addPrologueDirectivesAndInitialSuperCall(ctor: ConstructorDeclaration, result: Statement[]): number { |
Contributor
There was a problem hiding this comment.
There's already an addPrologueDirectives function. Can we that instead?
Contributor
Author
|
@rbuckton any other comments? |
| if (statement.kind === SyntaxKind.ExpressionStatement) { | ||
| const expression = (<ExpressionStatement>statement).expression; | ||
| if (expression.kind === SyntaxKind.CallExpression) { | ||
| if ((<CallExpression>expression).expression.kind === SyntaxKind.SuperKeyword) { |
Member
There was a problem hiding this comment.
There is an isSuperCallExpression function.
Member
|
👍 apart from the last comment I left. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don't assume that super call is the first statement in the list. Fixes #7877.