Report implicit any errors on destructuring declarations#7969
Merged
Conversation
Member
|
👍 |
| if (element.initializer) { | ||
| return getWidenedType(checkExpressionCached(element.initializer)); | ||
| const type = checkExpressionCached(element.initializer); | ||
| reportErrorsFromWidening(element, type); |
Member
There was a problem hiding this comment.
is this needed to make the new tests fail properly? If not, then does there need to be some test case that does need it to get the correct error message?
Member
Author
There was a problem hiding this comment.
this is needed for new test cases it gets covered by scenarios like
f([a=undefined]) {
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles #6935