Support getOccurrencesAtPosition for 'throw' keywords.#776
Merged
Conversation
Also revised behavior for 'return' keywords in that when the position resides on a 'return' statement, 'throw' keywords in the same function scope that are not within a try-block are also highlighted.
Contributor
There was a problem hiding this comment.
this code looks duplicated.
Contributor
|
👍 |
A try-block now only owns a throw statement if its try statement has a catch-clause.
Contributor
There was a problem hiding this comment.
I find this comment a little misleading... What do you mean by next owner? Really you want to convey that you are only counting "uncaught" throw statements (from the perspective of the initial Node).
Contributor
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 30, 2014
Support getOccurrencesAtPosition for 'throw' keywords.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also revised behavior for 'return' keywords in that when the position resides on a 'return' statement, 'throw' keywords in the same function scope that are not within a try-block are also highlighted.
Fixes #768