Transforms fix type errors#7675
Merged
Merged
Conversation
| } | ||
| }); | ||
|
|
||
| function ProgressBar(title) { |
Member
There was a problem hiding this comment.
Shouldn't this be in its own file? And I thought we already used an existing progress bar. Why write our own?
Contributor
Author
There was a problem hiding this comment.
That one is part of a mocha reporter. This Is used by a task that runs mocha using the TAP reporter so there is no progress. It's just something small I threw together so you know something is still happening.
Contributor
Author
There was a problem hiding this comment.
That library doesn't work well when running node in Powershell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes for transforms.
Cc: @vladima