Adjust sig help implementation to match the new simpler sig help API.#760
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
This could be made simpler by computing this data (argIndex and argCount) as we go through the process of finding the argument list given our position. However, that was not the concern of this change. What i wanted to do here was remove the multiple entrypoints for SigHelp and move us to teh single entrypoint that matches the host side of things.
If anyone wants to go and clean up sig help now that there is no longer multiple entrypoints, feel free :)
Contributor
Author
|
@JsonFreeman Signs off. |
CyrusNajmabadi
added a commit
that referenced
this pull request
Sep 26, 2014
Adjust sig help implementation to match the new simpler sig help API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.