Skip to content

Use fileExists check for file system case sensitivity instead of relying on the platform#7552

Closed
zhengbli wants to merge 1 commit into
microsoft:masterfrom
zhengbli:fixCaseSensitivityCheck
Closed

Use fileExists check for file system case sensitivity instead of relying on the platform#7552
zhengbli wants to merge 1 commit into
microsoft:masterfrom
zhengbli:fixCaseSensitivityCheck

Conversation

@zhengbli
Copy link
Copy Markdown

Fixes #7154

@zhengbli zhengbli changed the title Use fileExists check instead of relies on the platform Use fileExists check for file system case sensitivity instead of relies on the platform Mar 16, 2016
@zhengbli zhengbli changed the title Use fileExists check for file system case sensitivity instead of relies on the platform Use fileExists check for file system case sensitivity instead of relying on the platform Mar 16, 2016
@zhengbli zhengbli force-pushed the fixCaseSensitivityCheck branch from 5a0f9ba to 5c76ff9 Compare March 16, 2016 22:24
@billti
Copy link
Copy Markdown
Member

billti commented Mar 16, 2016

I don't see how this helps in the commonly reported case where folks are opening projects off mapped drives. This checks __filename, which is the currently executing file (i.e. tsserver.ts), which is likely installed locally with the editor (or plugin), not on the mapped drive where a project may live.

@vladima
Copy link
Copy Markdown
Contributor

vladima commented Mar 16, 2016

agree with @billti - the issue here is that case-sensitivity can vary between mounted volumes.

@zhengbli
Copy link
Copy Markdown
Author

Maybe it makes more sense for the useCaseSensitiveFileNames value to be a project property instead of a host property, because as pointed out it may vary from project to project.

@billti
Copy link
Copy Markdown
Member

billti commented Mar 17, 2016

Agree it makes more sense per project. I would test whatever the first file loaded for a project is (whether that be a .ts/.js file or the tsconfig.json file), as I doubt one project would be spread across volumes with different case sensitivity (and if they are... too bad).

@zhengbli
Copy link
Copy Markdown
Author

Close in light of #7658

@zhengbli zhengbli closed this Mar 23, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants