You could consider adding ./lib/**/* text eol=lf to the .gitattributes file to enforce this line ending scheme on clone.

👍

Why not use LF all the time?

IIRC, our .gitattributes say check in/out as-is, so committing it as line feeds will keep it that way.

Also, mentioning that this fixes #6630.

Assuming only LKG triggers turning off debug mode, this looks fine.

Couple of good points here. There are generally 2 flows:

• Someone builds locally and both publishes and checks in. In that case, how they check in/out the files doesn't matter (as they overwrote them when building locally), so we need to build with LF.
• Someone pulls the repo to get the latest and then publishes. In that case, it doesn't matter how we build locally if they just checked out the files they are publishing.

This changes addresses the first, @weswigham makes a good point and that would address the second. I'll update the .gitattributes.

@mhegazy Are you stating we should just use LF all the time (as in, for all files we build)? My concern there was I've seen many folks open/edit in historical tools such as Notepad for quick changes locally, which often don't handle LF line endings well. If we think this is a non-issue, I'm happy to make all build have LF line endings.

As a broader topic - why do we remove all conversion on our source and check-in/out "as-is"? Why not just normalize all src files (i.e. are LF in the repo, but OS specific when checked out)? Thus .gitattributes would look something like:

* text=auto
lib/* eol=lf

We have to keep things as-is so that our test cases don't get normalized -- this would cause the potential for bugs to slip through where tests passed on one OS but not the other (say, if we broke ASI only in the case where it was LF-only)

Ah, fair enough. Thanks @RyanCavanaugh (though we could still exclude just the tests dir only from normalization perhaps?)

FWIW: Making our ./lib directory be LF only by adding the line lib/* text eol=lf to .gitattributes makes that directory 430K smaller.

If it's possible to make /tests/ be as-is and everything else be OS-specific, that'd be great. I don't think we knew about that option of .gitattributes when we set up the repo.

already addressed by #9026