Skip to content

Expose ts.isExternalModule as public API.#7396

Merged
DanielRosenwasser merged 1 commit into
microsoft:masterfrom
mattmccutchen:issue7359
Mar 7, 2016
Merged

Expose ts.isExternalModule as public API.#7396
DanielRosenwasser merged 1 commit into
microsoft:masterfrom
mattmccutchen:issue7359

Conversation

@mattmccutchen
Copy link
Copy Markdown
Contributor

Fixes #7359

Since the entire namespace definition in src/compiler/utilities.ts is marked @internal, I just moved the definition of isExternalModule to another file. See the effect on the LKG. Also, jake runtests passed. Let me know if this should be done a different way.

@msftclas
Copy link
Copy Markdown

msftclas commented Mar 5, 2016

Hi @mattmccutchen, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@RyanCavanaugh
Copy link
Copy Markdown
Member

👍

DanielRosenwasser added a commit that referenced this pull request Mar 7, 2016
Expose ts.isExternalModule as public API.
@DanielRosenwasser DanielRosenwasser merged commit 01c329c into microsoft:master Mar 7, 2016
@mattmccutchen mattmccutchen deleted the issue7359 branch January 12, 2018 16:04
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants